Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Migrate AdhocFilterEditPopoverSqlTabContent to TypeScript #31268

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

refactor: Migrate AdhocFilterEditPopoverSqlTabContent to TypeScript #31268

wants to merge 4 commits into from
+135 −139

Conversation

EnxDev
Copy link
Contributor

@EnxDev EnxDev commented Dec 3, 2024

SUMMARY

Migrate AdhocFilterEditPopoverSqlTabContent to TypeScript

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Dec 3, 2024
EnxDev and others added 2 commits December 3, 2024 18:46
@EnxDev @justinpark
Update index.tsx
b38a13f 
Co-authored-by: JUST.in DO IT <[email protected]>
@EnxDev @justinpark
adds useMemo
f4022e6 
Co-authored-by: JUST.in DO IT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinpark justinpark justinpark left review comments

@geido geido Awaiting requested review from geido

@kgabryje kgabryje Awaiting requested review from kgabryje

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
change:frontend Requires changing the frontend size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EnxDev @justinpark