fix: code scanning alert no. 1226: Incomplete multi-character sanitization #31358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rusackas
changed the title
| let newstr = str; | ||
| do { | ||
| previous = newstr; | ||
| newstr = newstr.replace(/<[^>]*>/g, ''); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
There was a problem hiding this comment.
@dpgaspar this PR was opened by github as a fix for a CodeQL issue, and the solution it gives is another CodeQL issue. Curious if you have a take on whether we're better or worse off with this change :P
There was a problem hiding this comment.
@dpgaspar this PR was opened by github as a fix for a CodeQL issue, and the solution it gives is another CodeQL issue. Curious if you have a take on whether we're better or worse off with this change :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/apache/superset/security/code-scanning/1226
To fix the problem, we should ensure that all HTML tags are removed from the input string, even if they are nested or malformed. One way to achieve this is to repeatedly apply the regular expression replacement until no more replacements can be performed. This approach ensures that all instances of HTML tags are removed.
We will modify the
removeHTMLTagsfunction to apply the regular expression replacement in a loop until the input string no longer changes. This ensures that all HTML tags are removed, regardless of their structure.Suggested fixes powered by Copilot Autofix. Review carefully before merging.