Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fe): dev deps cleanup #31908

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Jan 17, 2025

chore(fe): dev deps cleanup

SUMMARY

  • I find these babel-plugin-typescript-to-proptypesandhtml-webpack-plugin` are of development nature. They are Babel/Webpack plugin respectively.
image
  • node-fetch as dev deps is obsolete as npm run test can be done without it.

  • xdm is no longer needed as npm run storybook is successful without it. The dep's omission removed 62 packages.

image image

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

All CI checks pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@hainenber hainenber changed the title chore(fe): move dev deps to correct block chore(fe): dev deps cleanup Jan 17, 2025
@sadpandajoe sadpandajoe requested a review from rusackas January 17, 2025 19:29
@sadpandajoe sadpandajoe added the review:checkpoint Last PR reviewed during the daily review standup label Jan 17, 2025
@mistercrunch
Copy link
Member

Tell me what you think, but I think effectively it doesn't matter what's dev or not dev dependencies as we simply build assets here and bundle a webpack package with everything that's needed as part of it. We could decide to put everything here as dev or non-dev and it wouldn't matter. It does matter in packages/ though, just not in this main package.json. I might be missing something though

@hainenber
Copy link
Contributor Author

Yes, there isn't a clear distinction so this is more of a definition correction for them Babel and Webpack plugin. There might be some vulnerability scanners employing heuristics of counting affected dependencies towards vulnerability count instead of devDeps so it might help there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies:npm review:checkpoint Last PR reviewed during the daily review standup size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants