WebResource read/write lock key changed to in lowercase arbitrarily #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix incorrect case sensitivity when the target base directory (dir name not in english) on windows is changed to case sensitive.
Detection of a directory case sensitivity is expansive, we have to create file with different upper/lower case name and check result. Both Linux and Windows allow case-sensitive/case-insensitive file systems to coexist. To avoid vulnerability, we simply treat all lock key as lowercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discarding the file name case sensitivity of resource directory.
Detection of a directory case sensitivity is expansive, we have to create file with different upper/lower case name and check result.
Based on talk in PR #820 .
To avoid vulnerability, we simply treat all lock key as lowercase.