Skip to content

Commit

Permalink
Updated node version from 18 to 20 (#8009)
Browse files Browse the repository at this point in the history
* Updated node version from 18 to 20 and added entry for CHANGELOG.md

* Updated node version from 18 to 20 in tpv2 package builder

* Added xvfb package in dockerfile

* Removed static node version name

* Fixed version to 20.0.0

* Removed duplicate checkout and cache module step.
  • Loading branch information
rimashah25 authored May 21, 2024
1 parent 3e77b60 commit a892235
Show file tree
Hide file tree
Showing 9 changed files with 3,224 additions and 3,217 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/chromdriver-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ jobs:
- name: Install Python 3.10
uses: actions/setup-python@v2
with: { python-version: '3.10' } # Must be quoted to include the trailing 0
- name: Install Node 18
- name: Install Node 20
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 20.x
- name: Install updater Python module and dependencies
run: pip install .github/actions/chromedriver-updater
- name: Run chromedriver-updater
Expand Down
14 changes: 9 additions & 5 deletions .github/workflows/tpv2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ name: Experimental Traffic Portal v2
env:
# alpine:3.13
ALPINE_VERSION: sha256:08d6ca16c60fe7490c03d10dc339d9fd8ea67c6466dea8d558526b1330a85930
NODE_VERSION: 18
NODE_VERSION: 20

on:
push:
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
restore-keys: |
${{ runner.os }}-node-
- name: Node 18
- name: Node ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}.x
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
restore-keys: |
${{ runner.os }}-node-
- name: Node 18
- name: Node ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}.x
Expand Down Expand Up @@ -125,7 +125,7 @@ jobs:
restore-keys: |
${{ runner.os }}-node-
- name: Node 18
- name: Node ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}.x
Expand Down Expand Up @@ -277,14 +277,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@master
uses: actions/checkout@main
with:
fetch-depth: 5
- name: Cache node modules
uses: actions/cache@v2
with:
path: ${{ github.workspace }}/.npm
key: ${{ runner.os }}-node-${{ env.NODE_VERSION }}-${{ hashFiles('./experimental/traffic-portal/package-lock.json') }}
- name: Node ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
with:
node-version: 20.x
- name: Build RPM
uses: ./.github/actions/build-rpms
env:
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- [#7999](https://github.com/apache/trafficcontrol/pull/7999) *Traffic Router*, *Traffic Monitor*, *Traffic Stats*: Symlink from /opt/<component>/var/log to /var/log/<component>. These symlinks are deprecated with the intent of removing them in ATC 9.0.0.
- [#7872](https://github.com/apache/trafficcontrol/issues/7872) *Traffic Router*: Updated Apache Tomcat from 9.0.43, 9.0.67, 9.0.83, and 9.0.86 to 9.0.87.
- [#7933](https://github.com/apache/trafficcontrol/pull/7933), [#8005](https://github.com/apache/trafficcontrol/pull/8005) *Traffic Portal v2*: Update NodeJS version to 18.
- [#8009](https://github.com/apache/trafficcontrol/pull/8009) *Traffic Portal v2*: Update NodeJS version to 20.

### Fixed
- [#8008](https://github.com/apache/trafficcontrol/pull/8008) *Traffic Router* Fix czf temp file deletion issue.
Expand Down
Loading

0 comments on commit a892235

Please sign in to comment.