[KVCache] Per Layer Sliding Window #17928
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-j-hong
changed the title
joshua-j-hong
force-pushed
the
jjhong_KV_alt_sliding_window
branch
from
3fb27bb to
936d500
Compare
|
With some further testing and investigation, there is an additional MLC-LLM/TVM bug related to excessive prefilling (even without the per-layer sliding window changes outlined here) that may be causing inference slowdown. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds per layer sliding window functionality to the KV Cache. Currently there are some major bugs that should be resolved before merging.