Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix configure for cross-compilation #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ayoubserti
Copy link

This pull request fix a cross-compilation issue:
When I try to configure for cross-compilation the script fails on wcsrtombs test.

@FerrixPlusPlus
Copy link

I have tested the fix on my environment ( Debian 10 with crossbuild-essential-armhf package ) and works fine.

@ayoubserti
Copy link
Author

Thank you @FerrixPlusPlus
Still the maintainer approval.

@rleigh-codelibre
Copy link
Contributor

Do you need to repeat the program source code? Or would AC_CHECK_FUNC be sufficient when cross-compiling?

Do the CMake checks in cmake/XercesWChar.cmake also need updating to cater for this scenario?

@ayoubserti
Copy link
Author

@rleigh-codelibre I'm not sure if AC_CHECK_FUNC compile and run or only compile.
In general, in cross-compiling the configure should use AC_COMPILE_IFELSE instead of AC_RUN_IFELSE

cmake/XercesWChar.cmake check compilation only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants