Skip to content

Commit

Permalink
Fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Shon Feder committed Jan 3, 2024
1 parent c26aae7 commit e37496b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ class TestIntOracle extends AnyFunSuite with BeforeAndAfterEach with Checkers {
}

// We cannot test getIndexOfChosenValueFromModel without running the solver
// Ignored until we figure out why it's killing GH CLI
test("getIndexOfChosenValueFromModel recovers the index correctly") {
val prop =
forAll(Gen.zip(maxSizeAndIndexGen)) { case (size, index) =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ class TestSparseOracle extends AnyFunSuite with BeforeAndAfterEach with Checkers
// which should have its own tests

// We cannot test getIndexOfChosenValueFromModel without running the solver
// Ignored until we figure out why it's killing GH CLI
ignore("getIndexOfChosenValueFromModel recovers the index correctly") {
test("getIndexOfChosenValueFromModel recovers the index correctly") {
val ctx = new Z3SolverContext(SolverConfig.default)
val paa = PureArenaAdapter.create(ctx) // We use PAA, since it performs the basic context initialization
val paa2 = paa.appendCell(IntT1) // also declares the cell
Expand All @@ -89,7 +88,8 @@ class TestSparseOracle extends AnyFunSuite with BeforeAndAfterEach with Checkers
ret
}

// 1000 is too many, since each run invokes the solver
check(prop, minSuccessful(80), sizeRange(4))
// The default minimum successful runs is 1000, but this is costly
// since each run invokes the solver.
check(prop, minSuccessful(50), sizeRange(4))
}
}

0 comments on commit e37496b

Please sign in to comment.