Skip to content
This repository was archived by the owner on Nov 8, 2024. It is now read-only.

Commit

Permalink
Move url to dev dependencies
Browse files Browse the repository at this point in the history
It's only needed when bundling for the browser
  • Loading branch information
realityking committed Nov 27, 2020
1 parent 2161fb3 commit a3f9488
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
7 changes: 5 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@
"http-string-parser": "0.0.6",
"json-pointer": "0.6.0",
"media-typer": "1.1.0",
"tv4": "1.3.0",
"url": "0.11.0"
"tv4": "1.3.0"
},
"devDependencies": {
"@rollup/plugin-json": "4.0.1",
Expand All @@ -70,7 +69,8 @@
"rollup-plugin-node-resolve": "5.2.0",
"rollup-plugin-terser": "5.3.0",
"semantic-release": "15.14.0",
"sinon": "7.5.0"
"sinon": "7.5.0",
"url": "0.11.0"
},
"repository": {
"type": "git",
Expand Down
5 changes: 5 additions & 0 deletions rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ const buildCjs = {
return true;
}

// url is a built-in module and should not be bundled either
if (id === 'url') {
return true;
}

return false;
},
plugins: [
Expand Down

0 comments on commit a3f9488

Please sign in to comment.