Skip to content

Clean up finished jobs after batch processing (#1144) #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from

Conversation

boobaa
Copy link
Contributor

@boobaa boobaa commented May 12, 2025

Fixes #1144

Copy link

codecov bot commented May 12, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 42.24%. Comparing base (fb6498d) to head (d967c29).

Files with missing lines Patch % Lines
..._teams/src/Controller/TeamMemberSyncController.php 0.00% 3 Missing ⚠️
src/Controller/DeveloperSyncController.php 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                4.x    #1145      +/-   ##
============================================
- Coverage     43.42%   42.24%   -1.19%     
  Complexity     3052     3052              
============================================
  Files           342      342              
  Lines         11150    11140      -10     
============================================
- Hits           4842     4706     -136     
- Misses         6308     6434     +126     
Files with missing lines Coverage Δ
src/JobExecutor.php 79.71% <ø> (ø)
src/Controller/DeveloperSyncController.php 54.71% <33.33%> (ø)
..._teams/src/Controller/TeamMemberSyncController.php 0.00% <0.00%> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@boobaa boobaa changed the base branch from 3.x to 4.x May 13, 2025 04:51
* @param string $tag
* Tag to filter with.
*/
public function cleanup(string $tag): void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this interface is considered a public API then it cannot be modified within this major version. As commented code with a todo for modifying the interface in 5.x can be added here.

@kedarkhaire
Copy link
Collaborator

Hi @boobaa
We reviewed the PR, and we have one suggestion to add in this implementation.

Instead of deleting all the entries, keep the details for last 1 month in the table with created or updated column.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The apigee_edge_job gets HUUUGE because nothing deletes from it
3 participants