Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code examples showing the need for synchronization #344

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cacay
Copy link
Member

@cacay cacay commented Feb 14, 2022

The PickANumber example demonstrates a bug in the compiler. The problem isn't with synchronization, however. It is to do with where declassify operations are performed. An operation let y = declassify x to l must be placed on a protocol that can read x, but we only require that it is placed on a protocol that can read y. This is a strictly bigger set of protocols, and causes certain values to be reveal before they should.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #344 (d1d6dd2) into master (f3ead9d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #344   +/-   ##
=========================================
  Coverage     58.96%   58.96%           
  Complexity     1128     1128           
=========================================
  Files           233      233           
  Lines          9094     9094           
  Branches       1362     1362           
=========================================
  Hits           5362     5362           
  Misses         3468     3468           
  Partials        264      264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ead9d...d1d6dd2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant