Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update context-matching logic to use earlier path edges if possible #3114

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sachindshinde
Copy link
Contributor

@sachindshinde sachindshinde commented Aug 12, 2024

This PR updates context-matching logic for @context/@fromContext to use earlier edges in the GraphPath if possible. (Also a bit of logic reorganizing for performance reasons.)

Specifically, if there are key resolution or root-type resolution edges prior to the match point in the graph path, then the context can be resolved at those edges to potentially generate more optimal query plans. (This should have occurred with the handleRequires logic being reapplied to contexts, but it wasn't happening for some reason.)

…tions prior to the match location, we shift the location earlier accordingly.
@sachindshinde sachindshinde requested a review from a team as a code owner August 12, 2024 15:42
Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: c94dcc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit c94dcc3
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/66ba2d68e6ccec0007f9cb8a

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@sachindshinde sachindshinde marked this pull request as draft August 12, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant