I have added logic to lookup os.environ 'URL_PREFIX' if exists use it instead of the DEFAULT_PREFIX #108
Conversation
Update app.py replace url_prefix '/cnr' with '/'
Update app.py replace url_prefix '/cnr' with '/'
|
@notjames @joejulian @ant31 Regards, |
|
@myselfram I'm not sure how much experience you have with github. If I may opine, you're kind of new to it. Taking a look at this project seems to indicate that it's probably a dead project considering no commits/PRs seem to have been done in over 5 years. Moreover, I thought this was a dead project as I thought appr was no longer necessary (I could be wrong there). Nevertheless, you've managed to get some attention of people in this project, but not the right people and it's possible you're not going to get the attention of a maintainer given the length of time this project has been updated. You might be better off forking this project and using your own fork for your needs rather than waiting for someone to commit/merge this PR. |
|
Also, in the open source world, patience is a must. You pinged me while I was on a 2 week vacation. No service, just trees, water, sea otters, and orcas. I'm not a contributor to this repo so I really have no idea what this PR is about or why it should or shouldn't be included and I really don't need negativity on my return from such a wonderful time away. Also, as Jim says, this hasn't seen a commit in years. That's not to say that the owner might not accept it, but it would require that they have the time to even take a look. Most folks have day jobs and only maintain these old repos in their spare time. Give people a break. Stand in their shoes. |
Joe, glad to hear you had a good vacation. Thanks for chiming in. |
| @@ -57,6 +57,8 @@ def _configure_endpoint(self, endpoint): | |||
| else: | |||
| scheme = "https://" | |||
| endpoint = scheme + endpoint | |||
| if 'URL_PREFIX' in os.environ: | |||
There was a problem hiding this comment.
please name it: APPR_URL_PREFIX and it should be good to merge
@notjames @joejulian @ant31
if my understanding is correct this should work, please review and help me merge this code.
Regards,
Ram