Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/setup tests #38

Closed
wants to merge 27 commits into from
Closed

Feature/setup tests #38

wants to merge 27 commits into from

Conversation

MartinSkatvedt
Copy link
Member

For now a WIP. But I included the action update in here.

@MartinSkatvedt MartinSkatvedt marked this pull request as draft January 14, 2021 19:53
MartinSkatvedt and others added 20 commits January 14, 2021 21:32
@MartinSkatvedt
added one more unit test
677f46e
@MartinSkatvedt
changed from js to tsx for tests
98012d6
@MartinSkatvedt
removed wrongly placed file
ad30707
@MartinSkatvedt
wrote snapshot tests and changed a p-tag to a span-tag in register.tsx
9550c27
@MartinSkatvedt
Merge branch 'main' into feature/setupTests
8693bcb
@MartinSkatvedt
deleted olcoins files
221a117
@MartinSkatvedt
added render test to navabr
b7dcf97
@MartinSkatvedt
added render test to Shopitem along with a mochProduct
70e2c35
@MartinSkatvedt
added render test to Basketwindow, which uses context
b28088c
@MartinSkatvedt
added integration test to basketWindow
2ce5b41
@MartinSkatvedt
fixed typo in importing
267c65b
@MartinSkatvedt
fixed a issue with modal root not rendering
563281c
@MartinSkatvedt
lint
38af3a0
@MartinSkatvedt
added render test to basketitem
edeaec5
@MartinSkatvedt
moved context stuff to setupTests
92ded4b
@MartinSkatvedt
add
8da4267
@MartinSkatvedt
added snapshot test to errormodal
9da4e03
@MartinSkatvedt
added some new snapshot tests for modals
d9a8e90
@MartinSkatvedt
added Storepage snapshot test
0fe7cb6
@MartinSkatvedt
added snapshot tests for app
56a3003
@MartinSkatvedt MartinSkatvedt marked this pull request as ready for review January 20, 2021 16:10
@MartinSkatvedt MartinSkatvedt marked this pull request as draft January 20, 2021 16:11
@MartinSkatvedt MartinSkatvedt marked this pull request as ready for review January 22, 2021 00:07
@MartinSkatvedt MartinSkatvedt requested a review from Paalar January 22, 2021 00:07
@MartinSkatvedt MartinSkatvedt added the documentation Improvements or additions to documentation label Jan 22, 2021
@MartinSkatvedt MartinSkatvedt linked an issue Jan 22, 2021 that may be closed by this pull request
Implement unit testing #29
Open
@MartinSkatvedt
Copy link
Member Author

closes #29

Snapshot tests for all the components.
Still missing a test for making sure the modals still renders when they should, however I couldnt find a good test for this yet(since it uses react portals).

@MartinSkatvedt MartinSkatvedt deleted the feature/setupTests branch April 30, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paalar Paalar Awaiting requested review from Paalar

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement unit testing
1 participant
@MartinSkatvedt