Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set bundle id at the end to make arguments work properly in Devicectl#launchApp #2366

Merged
merged 2 commits into from
Mar 27, 2024
Merged

fix: set bundle id at the end to make arguments work properly in Devicectl#launchApp #2366

merged 2 commits into from
Mar 27, 2024

Conversation

KazuCocoa
Copy link
Member

@KazuCocoa KazuCocoa commented Mar 27, 2024 •
edited
Loading

Fixes appium/appium#19926

It looks like:

xcrun devicectl device process launch --device 00008020-000E5CDA0A23002E com.trident.WebDriverAgentRunner.xctrunner --terminate-existing --environment-variables '{"USE_PORT":"9900","WDA_PRODUCT_BUNDLE_IDENTIFIER":"com.trident.WebDriverAgentRunner.xctrunner"}'

does not apply arguments properly while it does not raise any errors. It should be:

xcrun devicectl device process launch --device 00008020-000E5CDA0A23002E --terminate-existing --environment-variables '{"USE_PORT":"9900","WDA_PRODUCT_BUNDLE_IDENTIFIER":"com.trident.WebDriverAgentRunner.xctrunner"}' com.trident.WebDriverAgentRunner.xctrunner

I tested this case before but as part of refactoring in the pr, changed the order. I thought it worked but did not in the fact...

I'll merge this after CI passes since this is just order modification

@KazuCocoa KazuCocoa mentioned this pull request Mar 27, 2024
Closed
3 tasks
@KazuCocoa KazuCocoa changed the title fix: set bundle id at the end to make arguments work properly fix: set bundle id at the end to make arguments work properly in launchApp#launchApp Mar 27, 2024
@KazuCocoa KazuCocoa changed the title fix: set bundle id at the end to make arguments work properly in launchApp#launchApp fix: set bundle id at the end to make arguments work properly in Devicectl#launchApp Mar 27, 2024
@KazuCocoa KazuCocoa merged commit 1d3fd28 into master Mar 27, 2024
18 checks passed
@KazuCocoa KazuCocoa deleted the fix-order-devicectl branch March 27, 2024 04:34
github-actions bot pushed a commit that referenced this pull request Mar 27, 2024
@semantic-release-bot
chore(release): 7.6.1 [skip ci]
be49758 
## [7.6.1](v7.6.0...v7.6.1) (2024-03-27)

### Bug Fixes

* set bundle id at the end to make arguments work properly in Devicectl[#launch](https://github.com/appium/appium-xcuitest-driver/issues/launch)App ([#2366](#2366)) ([1d3fd28](1d3fd28))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 7.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: WDA getStatus keeps waiting when giving wdaLocalPort
1 participant
@KazuCocoa