Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tune error handling with usePreinstalledWDA #2368

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

KazuCocoa
Copy link
Member

No description provided.

errorMsg = `Unable to launch WebDriverAgent. Original error: ${err.message}. ` +
`Make sure the application ${this.wda.bundleIdForXctest} exists and it is launchable.`;
if (this.isRealDevice()) {
errorMsg += ` ${WDA_REAL_DEV_TUTORIAL_URL} may help to complete the preparation.`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this tutorial only relevant for real devices?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the page can have more links to some pages with proper descriptions, but I think the page can be the primary entry point for an error message.
-> https://appium.github.io/appium-xcuitest-driver/latest/preparation/real-device-config/

@KazuCocoa KazuCocoa merged commit 1a5aafd into master Mar 28, 2024
18 checks passed
@KazuCocoa KazuCocoa deleted the tune-prebuiltwda branch March 28, 2024 03:18
github-actions bot pushed a commit that referenced this pull request Mar 28, 2024
## [7.7.1](v7.7.0...v7.7.1) (2024-03-28)

### Miscellaneous Chores

* tune error handling with usePreinstalledWDA ([#2368](#2368)) ([1a5aafd](1a5aafd))
Copy link
Contributor

🎉 This PR is included in version 7.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants