-
Notifications
You must be signed in to change notification settings - Fork 567
feat: add method for interacting with the Flutter integration driver #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add method for interacting with the Flutter integration driver #1123
Conversation
appium/webdriver/extensions/flutter_integration/flutter_commands.py
Outdated
Show resolved
Hide resolved
text (Optional[str]): The text of the widget to filter by. | ||
|
||
Returns: | ||
List[Optional[Dict]]: A list of dictionaries or None values representing the render tree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might probably be useful to provide some examples of the output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the main comment with the output examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure the recent changes have been committed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean that the output examples should be included in the function's docstring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, one or two would be enough for the returned value docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added example for the returned value in the docstring
Hi,
This PR adds a method for interacting with the Flutter integration driver. It adds partial filter support and render tree retrieval.
Please let me know if any changes or improvements are needed.
Thanks!
This is an example of the output for this method, based on the rendering of this application
REQUEST of the existing class
RESPONSE
REQUEST for a non-existent widget
RESPONSE
REQUEST without parameters to retrieve all widgets from the root
RESPONSE