Skip to content

fix: Corehaptics.AssetPickerDrawer throws exceptions and draws incorrectly when fieldInfo or assetType is null #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Corehaptics.AssetPickerDrawer throws exceptions and draws incorrectly when fieldInfo or assetType is null #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28b76d7
fix: UnityPickers.AssetPickerDrawer throws exception when fieldInfo i…
ilterbilguven Feb 5, 2025
5bc23d2
fix: UnityPickers.AssetPickerDrawer throws exception when assetType i…
ilterbilguven Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...Apple.CoreHaptics_Unity/Assets/Apple.CoreHaptics/Editor/UnityPickers/AssetPickerDrawer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,23 @@ public class AssetPickerDrawer : PropertyDrawer
{
public override void OnGUI(Rect position, SerializedProperty property, GUIContent label)
{
if (fieldInfo == null)
{
// If fieldInfo is null, draw the property field as is.
EditorGUI.PropertyField(position, property, label);
return;
}

var assetType = fieldInfo.FieldType;
if (assetType.IsUnityCollection())
assetType = assetType.GetElementType();

if (assetType == null)
{
// If assetType is null, draw the property field as is.
EditorGUI.PropertyField(position, property, label);
return;
}

var a = fieldInfo.GetAttribute<AssetPickerAttribute>();

Expand Down