Allow cleanup of successful jobs #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastjan
changed the title
successfulJobsHistoryLimit to UpgradeConfig spec
simu
approved these changes
Jan 28, 2025
bastjan
force-pushed
the
cleanup-successful-jobs
branch
2 times, most recently
from
8655bd7 to
43ca59e
Compare
Allows cleanup of older successful jobs. I did not add the same field for failed jobs since they need to be cleaned up manually anyways. It is not possible by design to delete the most recent successful job.
bastjan
force-pushed
the
cleanup-successful-jobs
branch
from
43ca59e to
6ac0b24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows cleanup of older successful jobs.
Adds
successfulJobsHistoryLimittoUpgradeConfigspec. Defaults to4, roughly one month if updating weekly.I did not add the same field for failed jobs since they need to be cleaned up manually anyways. It is not possible by design to delete the most recent successful job.
Fixes #118.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog