Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: $page usage to page #1771

Merged
merged 3 commits into from
Apr 1, 2025
Merged

Refactor: $page usage to page #1771

merged 3 commits into from
Apr 1, 2025

Conversation

ItzNotABug
Copy link
Member

What does this PR do?

Note -

  1. Partial Svelte5 migration with page logic

    • Children slots not recognised
    • Component <> ComponentType issues from Pink2 & Pink2 Icons.
    • Failing imports to Components and Types from library/dist paths

  2. $page logic is untouched where we still use subscribe & derived(page, ($page) => {...})

Test Plan

Well, wdyt!?

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes.

@ItzNotABug ItzNotABug self-assigned this Apr 1, 2025
@ItzNotABug ItzNotABug marked this pull request as ready for review April 1, 2025 13:44
@TorstenDittmann TorstenDittmann merged commit 2a76074 into feat-pink-v2 Apr 1, 2025
0 of 2 checks passed
@TorstenDittmann TorstenDittmann deleted the svelte5-migration branch April 1, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann Awaiting requested review from TorstenDittmann

Assignees

@ItzNotABug ItzNotABug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ItzNotABug @TorstenDittmann