-
Notifications
You must be signed in to change notification settings - Fork 3
Start of code to convert chapters and reqs #3
Conversation
Hey Luke, This is exciting- I can't wait to take them for a spin on my course! Let's definitely map out how to proceed. I should not be listed as an author of the package if my only contributions are to name the package and create the initial infrastructure. But, going forward from here, I can see a few scenarios:
I'll leave the current PR unmerged until I hear back from you. Just so you know, I'm taking some time off this week so I'll be back reliably online next week. Thanks! *on second thought, no matter what, I think the primary repo should live in your GitHub. LMK what you think. |
Great suggestions! Um, I don't mind writing docs, but that would be great if you could take the lead on that! I'm still working away on putting my scripts into function form, but you can definitely get started writing the docs. And ok, that makes sense about the primary repo being on my GitHub. And no worries, enjoy the week (vacation? break?) |
Reworks the paths to use the dc_path and lrnr_pkg_path.
@apreshill hey! I've written a working version that converts the files to the learnr format. See lwjohnst86#4. Test it out! I'd love to hear how it works! I'm closing this PR :) |
Hi @apreshill! I've started to convert my scripts into functions and put them into the package.
Question, since I haven't encountered a situation like this... I've cloned your repo, but I've written the code.. so who becomes the "cre" and who goes on the LICENSE? I usually make my own packages or contribute to already well developed packages, and I've never been in the situation of contributing to a package that was just started so I don't know how these things work... thoughts?