Core Script Builder Codegen Logic #14168
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| [package] | ||
| name = "aptos-dynamic-transaction-composer" | ||
| description = "Generating Move Script from a batched Move calls" | ||
| version = "0.1.0" | ||
|
|
||
| # Workspace inherited keys | ||
| authors = { workspace = true } | ||
| edition = { workspace = true } | ||
| homepage = { workspace = true } | ||
| license = { workspace = true } | ||
| publish = { workspace = true } | ||
| repository = { workspace = true } | ||
| rust-version = { workspace = true } | ||
|
|
||
| [lib] | ||
| crate-type = ["cdylib", "rlib"] | ||
|
|
||
| [dependencies] | ||
| anyhow = { workspace = true } | ||
| bcs = { workspace = true } | ||
| getrandom = { workspace = true, features = ["js"] } | ||
| hex = { workspace = true } | ||
| move-binary-format = { workspace = true } | ||
| move-bytecode-verifier = { workspace = true } | ||
| move-core-types = { workspace = true } | ||
| reqwest = { version = "*", features = ["blocking"] } | ||
|
There was a problem hiding this comment. Why not workspace here? There was a problem hiding this comment. The reason why I'm avoiding workspace is this repo will be compiled into WASM and thus might have different dependencies and I don't want to pollute the main workspace because of that. There was a problem hiding this comment. Yeah, I started to think how we deal with THAT. As a matter of fact, you have to pull in significant other parts of the code which already have workspace dependencies. We need a more general solution for this problem. I'm not sure whether there is something like 'dependency override' in cargo. Or perhaps for the WASM build, we need to generate the build config by our own script, that is generate source for a crate then compile it. For now I think this should be workspace too, it doesn't appear to solve the problem this way. There was a problem hiding this comment. Still needs resolution. Not using workspace doesn't help here. Also "*" is not our practice, should be a concrete version. |
||
| serde = { workspace = true } | ||
| serde_bytes = { workspace = true } | ||
| serde_json = { workspace = true } | ||
| tsify-next = "0.5.4" | ||
|
|
||
| wasm-bindgen = "0.2" | ||
| wasm-bindgen-futures = "0.4.42" | ||
|
|
||
| [dev-dependencies] | ||
| aptos-types = { workspace = true } | ||
| e2e-move-tests = { path = "../e2e-move-tests" } | ||
|
|
||
| [package.metadata.cargo-machete] | ||
| ignored = ["serde_bytes", "wasm-bindgen-futures", "getrandom"] | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that important, but I think on this level
transaction-composerwould be good enough, 'dynamic' is more like an extra marketing attribute. Moving forward, we will just call it on technical level the 'transaction composer' anyway, three words too long.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll rename this folder after a stamp. Brian suggested that renaming will dismiss previous commments