Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zeroize #15905

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Update zeroize #15905

merged 2 commits into from
Feb 8, 2025

Conversation

heliuchuan
Copy link
Contributor

@heliuchuan heliuchuan commented Feb 7, 2025

Description

Using aptos-types may not be possible in other repos if they require a zeroize version >1.3. This updates the version used to 1.6.

The dependency for x25519-dalek is upgraded to this version - aptos-labs/x25519-dalek@b9cdbaf, which uses zeroize 1.6

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Feb 7, 2025

⏱️ 1h 1m total CI duration on this PR
Job Cumulative Duration Recent Runs
execution-performance / single-node-performance 32m 🟥🟩
rust-doc-tests 7m 🟩
check-dynamic-deps 6m 🟩🟩🟩
test-target-determinator 4m 🟩
execution-performance / test-target-determinator 4m 🟩
rust-cargo-deny 3m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
semgrep/ci 1m 🟩🟩🟩
general-lints 1m 🟩🟩
file_change_determinator 21s 🟩🟩
file_change_determinator 10s 🟩
permission-check 10s 🟩🟩🟩
permission-check 9s 🟩🟩🟩
determine-docker-build-metadata 3s 🟩
permission-check 2s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 25m 13m +92%

settingsfeedbackdocs ⋅ learn more about trunk.io

@heliuchuan heliuchuan enabled auto-merge (squash) February 8, 2025 06:47

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Feb 8, 2025

✅ Forge suite compat success on 255673e8f2757ed8634a7d65d7aca11de7016cde ==> cd61a90fa6fff2163110f0ec7d8f2fa77c210584

Compatibility test results for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> cd61a90fa6fff2163110f0ec7d8f2fa77c210584 (PR)
1. Check liveness of validators at old version: 255673e8f2757ed8634a7d65d7aca11de7016cde
compatibility::simple-validator-upgrade::liveness-check : committed: 11743.82 txn/s, latency: 2751.52 ms, (p50: 2700 ms, p70: 2900, p90: 3900 ms, p99: 4800 ms), latency samples: 386260
2. Upgrading first Validator to new version: cd61a90fa6fff2163110f0ec7d8f2fa77c210584
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 3486.53 txn/s, latency: 8665.93 ms, (p50: 9300 ms, p70: 10200, p90: 11200 ms, p99: 11400 ms), latency samples: 80500
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3379.50 txn/s, latency: 10194.36 ms, (p50: 11000 ms, p70: 11700, p90: 11800 ms, p99: 11800 ms), latency samples: 128320
3. Upgrading rest of first batch to new version: cd61a90fa6fff2163110f0ec7d8f2fa77c210584
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 3319.88 txn/s, latency: 8990.03 ms, (p50: 9700 ms, p70: 10500, p90: 11300 ms, p99: 11500 ms), latency samples: 74480
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 3317.20 txn/s, latency: 10350.59 ms, (p50: 11300 ms, p70: 11500, p90: 11600 ms, p99: 11900 ms), latency samples: 127720
4. upgrading second batch to new version: cd61a90fa6fff2163110f0ec7d8f2fa77c210584
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 6190.24 txn/s, latency: 4906.96 ms, (p50: 5700 ms, p70: 5800, p90: 6400 ms, p99: 6600 ms), latency samples: 117880
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6152.37 txn/s, latency: 5580.44 ms, (p50: 5800 ms, p70: 6400, p90: 6900 ms, p99: 7100 ms), latency samples: 209700
5. check swarm health
Compatibility test for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> cd61a90fa6fff2163110f0ec7d8f2fa77c210584 passed
Test Ok

Copy link
Contributor

github-actions bot commented Feb 8, 2025

✅ Forge suite realistic_env_max_load success on cd61a90fa6fff2163110f0ec7d8f2fa77c210584

two traffics test: inner traffic : committed: 12946.48 txn/s, submitted: 12963.95 txn/s, expired: 17.46 txn/s, latency: 2969.10 ms, (p50: 2700 ms, p70: 3000, p90: 3300 ms, p99: 5300 ms), latency samples: 4922520
two traffics test : committed: 99.96 txn/s, latency: 1992.17 ms, (p50: 1900 ms, p70: 2200, p90: 2600 ms, p99: 3800 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.410, avg: 1.134", "ConsensusProposalToOrdered: max: 0.320, avg: 0.314", "ConsensusOrderedToCommit: max: 0.954, avg: 0.717", "ConsensusProposalToCommit: max: 1.266, avg: 1.031"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.47s no progress at version 1965946 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.85s no progress at version 1965904 (avg 0.85s) [limit 16].
Test Ok

Copy link
Contributor

github-actions bot commented Feb 8, 2025

✅ Forge suite framework_upgrade success on 255673e8f2757ed8634a7d65d7aca11de7016cde ==> cd61a90fa6fff2163110f0ec7d8f2fa77c210584

Compatibility test results for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> cd61a90fa6fff2163110f0ec7d8f2fa77c210584 (PR)
Upgrade the nodes to version: cd61a90fa6fff2163110f0ec7d8f2fa77c210584
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1796.34 txn/s, submitted: 1801.86 txn/s, failed submission: 5.52 txn/s, expired: 5.52 txn/s, latency: 1577.91 ms, (p50: 1500 ms, p70: 1700, p90: 2200 ms, p99: 3700 ms), latency samples: 162722
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1813.25 txn/s, submitted: 1819.25 txn/s, failed submission: 5.47 txn/s, expired: 6.00 txn/s, latency: 1554.60 ms, (p50: 1500 ms, p70: 1800, p90: 2300 ms, p99: 3600 ms), latency samples: 165891
5. check swarm health
Compatibility test for 255673e8f2757ed8634a7d65d7aca11de7016cde ==> cd61a90fa6fff2163110f0ec7d8f2fa77c210584 passed
Upgrade the remaining nodes to version: cd61a90fa6fff2163110f0ec7d8f2fa77c210584
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1690.82 txn/s, submitted: 1695.89 txn/s, failed submission: 5.07 txn/s, expired: 5.07 txn/s, latency: 1692.96 ms, (p50: 1700 ms, p70: 1800, p90: 2400 ms, p99: 3400 ms), latency samples: 153320
Test Ok

@heliuchuan heliuchuan merged commit 65525b6 into main Feb 8, 2025
77 of 89 checks passed
@heliuchuan heliuchuan deleted the update-zeroize branch February 8, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants