Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ross fix empty data #42

Merged
merged 7 commits into from
Feb 10, 2021
Merged

Ross fix empty data #42

merged 7 commits into from
Feb 10, 2021

Conversation

rosswhitaker
Copy link
Contributor

This resolves the bug of out-of-range index in the createModel function, which was caused by a condition of "no sensor data". That bug came to light because the map_reconfigure is making requests for model estimates in the future, which have no data (obviously). Those future requests are because map_reconfigure is making requests in GMT (or Z) time zones, rather than the local time zone. To fix that, map_reconfigure was modified so that formatDateTime uses the current time zone. However, that needs to be tested and still may fail when the local time zone is different from the sensor time zone. That issue needs to be sill resolved.

@rosswhitaker
Copy link
Contributor Author

Another problem. In the case of zero data, the api now returns "NaN" for the variance, which is an acceptable number in python, but not js. We need to decide how we want to handle this. Here is a thread that covers some of this: https://stackoverflow.com/questions/6601812/sending-nan-in-json/6602204

@JackWilb
Copy link
Member

Running getEstimatesForLocation on the server now causes it to hit its memory limit. I'll open an issue to track resolving that.

@JackWilb
Copy link
Member

Running getEstimatesForLocation on the server now causes it to hit its memory limit. I'll open an issue to track resolving that.

#43

@JackWilb JackWilb merged commit 8090390 into master Feb 10, 2021
@JackWilb JackWilb deleted the Ross_fix_empty_data branch February 10, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants