Skip to content

Update to Selenium 4.28.1 +semver:feature #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

mialeska
Copy link
Contributor

No description provided.

@mialeska mialeska added dependencies Pull requests that update a dependency file java labels Feb 14, 2025
@mialeska mialeska self-assigned this Feb 14, 2025
Copy link

coderabbitai bot commented Feb 14, 2025

Walkthrough

This pull request updates several files across the project. The LICENSE file now reflects the new copyright year (2025). The pom.xml has upgraded dependency versions for aquality-selenium-core and testng, and modified the Maven assembly plugin configuration. Additionally, test files that work with the Selenium DevTools API now import version v132 instead of v131. There are no changes to the application’s logic or control flow.

Changes

File(s) Change Summary
LICENSE Updated copyright year from 2024 to 2025.
pom.xml Upgraded aquality-selenium-core (4.3.0 → 4.5.0) and testng (7.10.2 → 7.11.0); changed Maven assembly plugin goal from attached to single.
src/test/.../DeviceEmulationTest.java,
src/test/.../NetworkSpeedEmulationTest.java,
src/test/.../OverrideUserAgentTest.java
Updated Selenium DevTools API import statements from version v131 to v132.

Possibly related PRs

Suggested labels

enhancement

Poem

I'm a happy rabbit hopping with cheer,
Seeing updates bloom as the code draws near.
From LICENSE to tests, each change is new,
With dependencies and plugins all shining through.
A joyful skip in every line—hip, hip, hooray!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4dcec7b and 065a52d.

📒 Files selected for processing (5)
  • LICENSE (1 hunks)
  • pom.xml (3 hunks)
  • src/test/java/tests/usecases/devtools/DeviceEmulationTest.java (1 hunks)
  • src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java (1 hunks)
  • src/test/java/tests/usecases/devtools/OverrideUserAgentTest.java (1 hunks)
✅ Files skipped from review due to trivial changes (4)
  • LICENSE
  • src/test/java/tests/usecases/devtools/OverrideUserAgentTest.java
  • src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java
  • src/test/java/tests/usecases/devtools/DeviceEmulationTest.java
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: aquality-automation.aquality-selenium-java (Run tests)
  • GitHub Check: aquality-automation.aquality-selenium-java (Analyse code with SonarQube)
🔇 Additional comments (3)
pom.xml (3)

174-174: LGTM! Good update to use the preferred goal name.

The change from 'attached' to 'single' aligns with Maven best practices, as 'single' is the preferred goal name since Maven 3.


112-112:

✅ Verification successful

Verify compatibility with Selenium 4.28.1

The update to TestNG 7.11.0 needs verification with Selenium 4.28.1 mentioned in the PR title.


🌐 Web query:

Is TestNG 7.11.0 compatible with Selenium 4.28.1?

💡 Result:

TestNG 7.x versions are compatible with Selenium 4.x versions like 4.28.1, as confirmed by their integration in automation setups[1][3]. While the search results specifically mention TestNG 7.8 working with Selenium[1][3], minor updates within the same major version (e.g., TestNG 7.x) typically maintain backward compatibility unless explicitly stated otherwise[3][9].

Key Compatibility Insights:

  • TestNG Annotations: Supported across all recent Selenium versions[1][3].
  • Selenium Bindings: Java bindings for Selenium 4 work seamlessly with TestNG annotations like @Test, @DataProvider, etc.[1][6].
  • Versioning Practices: Both projects follow semantic versioning; minor/patch updates (e.g., TestNG 7.87.11) rarely introduce breaking changes[3][9].

For confirmation, check dependency management tools like Maven or Gradle for conflicts between org.testng:testng:7.x and org.seleniumhq.selenium:selenium-java:4.x[2][3]. No incompatibilities are reported in official documentation or community forums[9].

Conclusion: Yes, TestNG 7.x (including 7.11) works with Selenium 4.x (including 4.28)[1][3][9].

Citations:


Compatibility Verified: TestNG 7.11.0 and Selenium 4.28.1

The web query confirms that TestNG 7.x (including 7.11.0) is compatible with Selenium 4.x (including 4.28.1). No additional changes or dependency updates are required in the pom.xml.


85-85:

✅ Verification successful

Verify compatibility with Selenium 4.28.1

The update to aquality-selenium-core 4.5.0 needs verification with Selenium 4.28.1 mentioned in the PR title.


🌐 Web query:

What version of Selenium WebDriver is supported by aquality-selenium-core 4.5.0?

💡 Result:

The aquality-selenium-core library does not directly specify its supported Selenium WebDriver version in the provided search results, but we can infer compatibility from related releases:

1. Aquality Selenium Java (which depends on aquality-selenium-core) v4.x.x aligns with specific Selenium WebDriver versions:

  • v4.* updates explicitly reference Selenium WebDriver ≥4.*, such as:
    • v4.**10**.0 uses Selenium 4.27.0 [3]
    • v4.**9**.0 uses Selenium 4.25.0 [3]
    • v4.**8**.0 uses Selenium 4.24.0 [3]
    • v4.**7**.1 uses Selenium 4.22.0 [3]

2. For aquality-selenium-core, since it serves as a dependency for these releases and follows semantic versioning compatibility rules:

  • Core versions matching major releases (e.g., v.x) would support corresponding major/minor versions of Selenium WebDriver used by sibling libraries like aquality-selenium-java.

Thus, aquality-skeleton-core v would likely support Seleniunm WebDriver ≥...* based on sibling library dependencies[3][9].

Citations:


Compatibility Verification for aquality-selenium-core 4.5.0

Based on the available information, aquality-selenium-core 4.5.0 is designed for Selenium 4.x releases. In related releases (such as aquality-selenium-java), versions in the 4.x series have been paired with Selenium WebDriver versions ranging from 4.22.0 up to 4.27.0. Given that Selenium 4.28.1 is a minor update and adheres to semantic versioning, it is reasonable to infer that aquality-selenium-core 4.5.0 remains compatible with Selenium 4.28.1.

  • aquality-selenium-core update: Version 4.5.0 shows expected backward compatibility with the Selenium 4.x series.
  • TestNG update: Version 7.11.0 is a minor version bump and should be compatible as well.
  • Maven assembly plugin: Changing the goal from "attached" to "single" follows current best practices with Maven 3.

Please ensure that integration tests are run to confirm compatibility in your specific environment.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mialeska mialeska merged commit b55fc89 into master Feb 14, 2025
2 of 4 checks passed
@mialeska mialeska deleted the enhancement/update-to-selenium-4.28.1 branch February 14, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant