Resolved review suggestions of 'order by kth column'

* Also const-corrected a couple of order_by_t's methods
aquarist-labs · Apr 2, 2022 · faed41a · faed41a
1 parent f4c9052
commit faed41a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/dev/conditions.h b/dev/conditions.h
@@ -446,13 +446,13 @@ namespace sqlite_orm {
 
             order_by_t(expression_type expression_) : order_by_base(), expression(std::move(expression_)) {}
 
-            self asc() {
+            self asc() const {
                 auto res = *this;
                 res.asc_desc = 1;
                 return res;
             }
 
-            self desc() {
+            self desc() const {
                 auto res = *this;
                 res.asc_desc = -1;
                 return res;

diff --git a/dev/literal.h b/dev/literal.h
@@ -1,7 +1,5 @@
 #pragma once
 
-#include <utility>  //  std::move
-
 namespace sqlite_orm {
     namespace internal {
 
@@ -12,7 +10,7 @@ namespace sqlite_orm {
         struct literal_holder {
             using type = T;
 
-            T value;
+            type value;
         };
 
     }

diff --git a/include/sqlite_orm/sqlite_orm.h b/include/sqlite_orm/sqlite_orm.h
@@ -2756,8 +2756,6 @@ namespace sqlite_orm {
 
 // #include "literal.h"
 
-#include <utility>  //  std::move
-
 namespace sqlite_orm {
     namespace internal {
 
@@ -2768,7 +2766,7 @@ namespace sqlite_orm {
         struct literal_holder {
             using type = T;
 
-            T value;
+            type value;
         };
 
     }
@@ -3203,13 +3201,13 @@ namespace sqlite_orm {
 
             order_by_t(expression_type expression_) : order_by_base(), expression(std::move(expression_)) {}
 
-            self asc() {
+            self asc() const {
                 auto res = *this;
                 res.asc_desc = 1;
                 return res;
             }
 
-            self desc() {
+            self desc() const {
                 auto res = *this;
                 res.asc_desc = -1;
                 return res;