Updating fork #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated skin parsing to use JSON
bottom text
Benefits of switching to Gradle (6.6.1): - Gradle can be used without Eclipse, or any IDE at all! It can even be used with Eclipse! - Building is faster and much more convenient than manually exporting a runnable .jar. - Manually locating dependencies is a thing of the past as well! Libraries are automatically downloaded for you! - This script even has Maven publication support! Why didn’t I do this earlier??
Now uploads artifacts...?
TODO: Read version from somewhere instead of having String constants, clean up text, and improve load times.
- yeeted java.util.Base64 as it doesn't exist in Java 7, replaced it with Kevin Kelley's decoder. Hopefully it should work fine, but I'm too tired to test it thoroughly right now. - Fixed a really minor potential resource leak in ListmapsHandler.
Anti-crab'd!
…, attempt to work out Github actions No clue if this will work!
I hope this works!
The buildscript is now worse!
Should hopefully be compatible with Gradle 7 when it comes out!
…ilds more reproducible As much as I appreciated it, Kevin Kelley's Base64 might be a little out of date. Hopefully shadowing apache commons will work, as it says it should be Java 7 compatible.
Libraries aren't cached for releases in case the cache accidentally holds on to the wrong version of a library or something else as highly implausible as that...
…ther applications
Due to shadowing, a copy of this gets put into meta-inf.
If Mojang wants to pretty-print their JSON files, we're now prepared!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting up to date with NeRd's fork, might try doing some things in a bit