[task]: Introduce namespaces io manage system resources #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure-stars
force-pushed
the
monolithic
branch
from
e01c8c9 to
7ab1d2a
Compare
Azure-stars
force-pushed
the
monolithic
branch
from
7ab1d2a to
801de3c
Compare
Azure-stars
force-pushed
the
monolithic
branch
2 times, most recently
from
572dcea to
4bd7557
Compare
equation314
reviewed
Nov 13, 2024
…hem before entering app main
Azure-stars
force-pushed
the
monolithic
branch
from
4bd7557 to
ea19a87
Compare
Azure-stars
force-pushed
the
monolithic
branch
from
e38cb09 to
aabfe88
Compare
equation314
reviewed
Dec 5, 2024
| @@ -186,6 +186,8 @@ pub extern "C" fn rust_main(cpu_id: usize, dtb: usize) -> ! { | |||
| info!("Primary CPU {} init OK.", cpu_id); | |||
| INITED_CPUS.fetch_add(1, Ordering::Relaxed); | |||
|
|
|||
| ctor_bare::call_ctors(); | |||
There was a problem hiding this comment.
Put it before line 186, or other CPU may enter main before calling ctors.
| /// | ||
| /// It provides methods to lazily initialize the resource of the current thread, | ||
| /// or to share the resource with other threads. | ||
| pub struct AxResource<T>(LazyInit<Arc<T>>); |
There was a problem hiding this comment.
Is ResArc clearer and shorter?
| RwLock::new(fd_table) | ||
| }; | ||
| def_resource! { | ||
| #[allow(non_camel_case_types)] |
|
|
||
| #[ctor_bare::register_ctor] | ||
| #[cfg(feature = "fd")] | ||
| fn init_stdio() { |
| @@ -15,10 +15,34 @@ fn make_disk() -> std::io::Result<RamDisk> { | |||
| Ok(RamDisk::from(&data)) | |||
| } | |||
|
|
|||
| mod axns_imp { | |||
There was a problem hiding this comment.
If we only test the global namespace, can we avoid adding this code?
| @@ -90,6 +90,12 @@ fn kernel_image_regions() -> impl Iterator<Item = MemRegion> { | |||
| flags: MemRegionFlags::RESERVED | MemRegionFlags::READ, | |||
| name: ".rodata", | |||
| }, | |||
| MemRegion { | |||
| paddr: virt_to_phys((_sinit_array as usize).into()), | |||
| size: _einit_array as usize - _sinit_array as usize, | |||
There was a problem hiding this comment.
Can we use __init_array_start and __init_array_end only?
| @@ -37,6 +37,10 @@ pub fn new_kernel_aspace() -> AxResult<AddrSpace> { | |||
| axconfig::KERNEL_ASPACE_SIZE, | |||
| )?; | |||
| for r in axhal::mem::memory_regions() { | |||
| if r.size == 0 { | |||
| info!("Skip zero-size memory region: {:?}", r); | |||
There was a problem hiding this comment.
Put the empty region check in map_linear/map_alloc/unmap/protect
| @@ -10,6 +10,7 @@ repository = "https://github.com/arceos-org/arceos/tree/main/modules/axfs" | |||
| documentation = "https://arceos-org.github.io/arceos/axfs/index.html" | |||
|
|
|||
| [features] | |||
| thread-local = ["axns/thread-local"] | |||
There was a problem hiding this comment.
Remove this feature and enable axns/thread-local in arceos-posix-api/uspace only.
| @@ -19,11 +19,12 @@ documentation = "https://arceos-org.github.io/arceos/arceos_posix_api/index.html | |||
| [features] | |||
| default = [] | |||
|
|
|||
| uspace = ["axns/thread-local", "axfs/thread-local", "smp", "irq", "fs", "multitask", "net", "pipe", "select", "epoll"] | |||
There was a problem hiding this comment.
We only use uspace = ["axns/thread-local"] here, other features should be enabled in starry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.