Finishing implementing test for DataObjectEvent flow

src/DataObjectEventListener.php

@@ -2,9 +2,13 @@
 
 namespace ArchiPro\Silverstripe\EventDispatcher;
 
+use ArchiPro\EventDispatcher\ListenerProvider;
 use ArchiPro\Silverstripe\EventDispatcher\Event\DataObjectEvent;
 use ArchiPro\Silverstripe\EventDispatcher\Event\Operation;
+use ArchiPro\Silverstripe\EventDispatcher\Service\EventService;
 use Closure;
+use SilverStripe\Core\Injector\Injectable;
+use SilverStripe\Core\Injector\Injector;
 use SilverStripe\ORM\DataObject;
 
 /**
@@ -16,6 +20,8 @@
  */
 class DataObjectEventListener
 {
+    use Injectable;
+
     /**
      * Creates a new DataObject event listener.
      *
@@ -31,6 +37,19 @@ public function __construct(
         $this->operations = $operations ?? Operation::cases();
     }
 
+    /**
+     * Registers this listener with the given provider.
+     *
+     * If no provider is provided, the global EventService will be used.
+     */
+    public function selfRegister(ListenerProvider|EventService $provider = null): void
+    {
+        if (empty($provider)) {
+            $provider = Injector::inst()->get(EventService::class);
+        }
+        $provider->addListener(DataObjectEvent::class, $this);
+    }
+
     /**
      * Handles a DataObject event.
      *

src/Event/DataObjectEvent.php

@@ -2,6 +2,7 @@
 
 namespace ArchiPro\Silverstripe\EventDispatcher\Event;
 
+use SilverStripe\Core\Extension;
 use SilverStripe\Core\Injector\Injectable;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\Security\Member;
@@ -118,17 +119,11 @@ public function getObject(bool $useVersion = false): ?DataObject
             return null;
         }
 
-        $object = DataObject::get_by_id($this->objectClass, $this->objectID);
-
-        // If we want the specific version and the object is versioned
-        if ($useVersion && $this->version && $object && $object->hasExtension(Versioned::class)) {
-            /** @var Versioned|DataObject $object */
-            return $object->Version == $this->version
-                ? $object
-                : $object->Versions()->byID($this->version);
+        if (!$useVersion || empty($this->version)) {
+            return DataObject::get_by_id($this->objectClass, $this->objectID, false);
         }
 
-        return $object;
+        return Versioned::get_version($this->objectClass, $this->objectID, $this->version);
     }
 
     /**

tests/php/Extension/EventDispatchExtensionTest.php

@@ -30,15 +30,12 @@ public static function setUpBeforeClass(): void
     {
         parent::setUpBeforeClass();
 
-        $service = Injector::inst()->get(EventService::class);
-
-        // Add listener that captures events
-        $service->addListener(DataObjectEvent::class, new DataObjectEventListener(
+        DataObjectEventListener::create(
             function (DataObjectEvent $event) {
                 static::$events[] = $event;
             },
             [SimpleDataObject::class, VersionedDataObject::class]
-        ));
+        )->selfRegister();
     }
 
     protected function setUp(): void