Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with DOI #3758

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

ddceruti
Copy link
Contributor

@ddceruti ddceruti commented Jan 15, 2025

Changed the details to include the published paper and update authors.

Summary by CodeRabbit

  • Documentation
    • Updated README.md for the German Building Stock Database
    • Refined description and citation details
    • Added new author Urbano Tataranni to the contributors list

Changed the details to include the published paper and update authors.
Copy link

coderabbitai bot commented Jan 15, 2025

Walkthrough

The pull request introduces updates to the README.md file for the German Building Stock Database. The changes primarily involve textual refinements, including clarifying language, updating references, and adding a new author. The modifications aim to improve the document's accuracy and readability by removing outdated phrases, specifying publication details, and expanding the list of contributors.

Changes

File Change Summary
cea/databases/DE/README.md - Refined description text
- Updated paper reference with DOI link
- Changed wording from "useful" to "helpful"
- Added new author Urbano Tataranni ([email protected])

Poem

🐰 A README's tale, now bright and clear,
With words that sparkle, references near
A new author joins the scholarly dance
Urbano brings knowledge, a scholarly chance
Database details, polished with care
A rabbit's delight, beyond compare! 📚✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
cea/databases/DE/README.md (1)

11-11: Add missing determiner "An" for grammatical correctness.

The sentence should begin with "An accompanying documentation.md file" for proper grammar.

-Building typology for the German building stock adapted to CEA database format. Accompanying documentation.md file details all assumptions and sources used to compile the database. Please cite the paper published at the BauSIM 2024 conference proceedings.
+Building typology for the German building stock adapted to CEA database format. An accompanying documentation.md file details all assumptions and sources used to compile the database. Please cite the paper published at the BauSIM 2024 conference proceedings.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~11-~11: A determiner appears to be missing. Consider inserting it.
Context: ...g stock adapted to CEA database format. Accompanying documentation.md file details all assum...

(AI_EN_LECTOR_MISSING_DETERMINER)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f9a5334 and 976b0f7.

📒 Files selected for processing (1)
  • cea/databases/DE/README.md (2 hunks)
🧰 Additional context used
🪛 LanguageTool
cea/databases/DE/README.md

[uncategorized] ~11-~11: A determiner appears to be missing. Consider inserting it.
Context: ...g stock adapted to CEA database format. Accompanying documentation.md file details all assum...

(AI_EN_LECTOR_MISSING_DETERMINER)


[style] ~13-~13: ‘overall goal’ might be wordy. Consider a shorter alternative.
Context: ...auSIM 2024 conference proceedings. The overall goal is to improve the current database crea...

(EN_WORDINESS_PREMIUM_OVERALL_GOAL)

🪛 Markdownlint (0.37.0)
cea/databases/DE/README.md

35-35: null
Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: windows-latest
  • GitHub Check: macos-latest
  • GitHub Check: ubuntu-latest
🔇 Additional comments (3)
cea/databases/DE/README.md (3)

13-13: Clear and well-structured goal statement.

The statement effectively communicates the project's purpose and collaborative nature.

🧰 Tools
🪛 LanguageTool

[style] ~13-~13: ‘overall goal’ might be wordy. Consider a shorter alternative.
Context: ...auSIM 2024 conference proceedings. The overall goal is to improve the current database crea...

(EN_WORDINESS_PREMIUM_OVERALL_GOAL)


18-21: Well-formatted citation with proper DOI link.

The citation has been properly updated with the published paper details and includes a correctly formatted DOI link, which aligns with academic standards.


35-35: Author information follows consistent format.

The new author entry maintains the established format and includes appropriate contact information.

🧰 Tools
🪛 Markdownlint (0.37.0)

35-35: null
Bare URL used

(MD034, no-bare-urls)

@ShiZhongming ShiZhongming merged commit 07f7688 into architecture-building-systems:master Jan 15, 2025
6 checks passed
@ShiZhongming
Copy link
Collaborator

Thanks for the updates. It is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants