Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove developer version in Windows setup #3765

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

reyery
Copy link
Member

@reyery reyery commented Jan 29, 2025

Resolves #3642

Removing the developer option from the Windows setup, since user would be able to link their local git repository to the conda environment manually using pip install -e PATH_TO_CEA.

Will update docs accordingly to reflect this change.

Summary by CodeRabbit

  • Chores
    • Simplified the installation process by removing the developer version repository cloning option
    • Streamlined the City Energy Analyst (CEA) installation workflow

Copy link

coderabbitai bot commented Jan 29, 2025

Walkthrough

The pull request involves modifying the cityenergyanalyst.nsi setup script by removing the section responsible for installing the developer version of City Energy Analyst (CEA) from a GitHub repository. This change eliminates the functionality that previously allowed users to clone the CEA repository during installation, effectively simplifying the installation process and removing the GitHub repository dependency.

Changes

File Change Summary
setup/cityenergyanalyst.nsi Removed developer version installation section, including repository cloning commands and related configuration

Assessment against linked issues

Objective Addressed Explanation
Fix CEA installation error [#3642]
Resolve developer version installation issues

Poem

🐰 A bunny's tale of install delight,
No more GitHub's tricky clone's might
Simplicity wins the day
Developer version fades away
Installation now smooth and bright! 🛠️


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07f7688 and 6f01718.

📒 Files selected for processing (1)
  • setup/cityenergyanalyst.nsi (0 hunks)
💤 Files with no reviewable changes (1)
  • setup/cityenergyanalyst.nsi
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: windows-latest
  • GitHub Check: macos-latest
  • GitHub Check: ubuntu-latest

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@reyery reyery merged commit a389671 into master Jan 29, 2025
8 checks passed
@reyery reyery deleted the remove-developer-version branch January 29, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CEA installation with .exe reported error and failed
1 participant