Fix Package template still linking to Flyspray instead of GitLab #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
requested changes
Jan 2, 2025
tracker/templates/package.html
Outdated
| <a href="https://bugs.archlinux.org/?project=0&order=id&sort=desc&string={{ package.pkgname|urlencode }}">bugs open</a> | | ||
| <a href="https://bugs.archlinux.org/?project=0&order=id&sort=desc&status%5B%5D=closed&string={{ package.pkgname|urlencode }}">bugs closed</a> | | ||
| <a href="https://gitlab.archlinux.org/archlinux/packaging/packages/{{ package.pkgname|urlencode }}-/issues">bugs open</a> | | ||
| <a href="https://gitlab.archlinux.org/archlinux/packaging/packages/{{ package.pkgname|urlencode }}/-/issues/?state=closed">bugs closed</a> | |
There was a problem hiding this comment.
This won't work, it needs to be encoded so afl++ goes to afl++ gitlab.
For that you need something like we have in archweb https://github.com/archlinux/archweb/blob/4e25b014e45c6e44658222e38e563767b839e187/main/utils.py#L156
There was a problem hiding this comment.
It has taken me a while, but I've update the commit to adapt that approach, but as a jinja filter.
I also figured out I can test this locally by manually adding a package to the db, and it seems to work fine.
thrimbor
force-pushed
the
outdated_flyspray_links
branch
from
8584e98 to
f7a694e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small change to fix some outdated links I found that still lead to bugs.archlinux.org instead of the GitLab.
I couldn't quickly figure out if and how a change like this is tested (almost all tests don't work on my machine even before the change), but the links should work fine like that.