Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The patches required to use C++ STL #493

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

The patches required to use C++ STL #493

wants to merge 2 commits into from

Conversation

KOLANICH
Copy link

These patches should be enough to use magic_enum library and std::string. For using CTRE other patches are needed, but they don't belong to this repo.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KOLANICH
Copy link
Author

It is likely these patches should be applied to other cores too.

@KOLANICH
Copy link
Author

CLA won't be signed, but everyone can consider original parts of my contribution as licensed under Unlicense license.

@matthijskooijman
Copy link
Collaborator

Thanks for your contribution!

I believe this might be already solved in https://github.com/arduino/ArduinoCore-API, which should be the base of this core as well in the future (also see arduino/ArduinoCore-API#140 which makes some additional related changes).

@KOLANICH
Copy link
Author

Thanks. Incorporated some changes from there.

@KOLANICH
Excluded the series of function-like macros out of extern "C"{ bloc…
5897ecd 
…k in `Arduino.h`.
@KOLANICH
Converted the series of function-like macros in Arduino.h into cons…
4ae6b26 
…texpr functions in the case of C++. Required in order to avoid conflicts to C++ stdlib.

Incorporates some of the changes from arduino/ArduinoCore-API#140 and arduino/ArduinoCore-API@30e4397
Co-Authored-By: Keating Reid <[email protected]>
Co-Authored-By: Martino Facchin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KOLANICH @CLAassistant @matthijskooijman @per1234