Ethernet library: add missing functions #160
Conversation
| void MACAddress(uint8_t *mac_address); | ||
| IPAddress localIP(); | ||
| IPAddress subnetMask(); | ||
| IPAddress gatewayIP(); | ||
| IPAddress dnsServerIP(); | ||
|
|
||
| void setMACAddress(const uint8_t *mac_address); | ||
| void setLocalIP(const IPAddress local_ip); | ||
| void setSubnetMask(const IPAddress subnet); | ||
| void setGatewayIP(const IPAddress gateway); | ||
| void setDnsServerIP(const IPAddress dns_server); |
There was a problem hiding this comment.
We can avoid overloading these methods
| } | ||
| public: | ||
| NetworkInterface() {} | ||
| ~NetworkInterface() {} |
There was a problem hiding this comment.
We should make this virtual
| ~NetworkInterface() {} | |
| virtual ~NetworkInterface() = default; |
| static void event_handler(struct net_mgmt_event_callback *cb, | ||
| uint64_t mgmt_event, | ||
| struct net_if *iface); | ||
|
|
||
| static void option_handler(struct net_dhcpv4_option_callback *cb, | ||
| size_t length, | ||
| enum net_dhcpv4_msg_type msg_type, | ||
| struct net_if *iface); |
There was a problem hiding this comment.
Could we make these methods into static functions in cpp file only? this way they are going to be hidden from the class definition
There was a problem hiding this comment.
Can you make the curly braces consistent in style?either on new line or at the end of the line
| void init(uint8_t sspin = 10); | ||
|
|
||
| int disconnect(void); | ||
| void end(void); |
| virtual ~EthernetClass() {} | ||
|
|
||
| int begin(uint8_t *mac = nullptr, unsigned long timeout = 60000, unsigned long responseTimeout = 4000); | ||
| int maintain(); |
| bool disconnect() { | ||
| return (net_if_down(netif) == 0); | ||
| } | ||
| int begin(bool blocking = true, uint32_t additional_event_mask = 0); |
| int begin(uint8_t *mac, IPAddress ip); | ||
| int begin(uint8_t *mac, IPAddress ip, IPAddress dns); | ||
| int begin(uint8_t *mac, IPAddress ip, IPAddress dns, IPAddress gateway); | ||
| int begin(uint8_t *mac, IPAddress ip, IPAddress dns, IPAddress gateway, IPAddress subnet, unsigned long timeout = 60000, unsigned long responseTimeout = 4000); | ||
|
|
||
| int begin(IPAddress ip) { | ||
| return begin(nullptr, ip); | ||
| } | ||
| int begin(IPAddress ip, IPAddress dns) { | ||
| return begin(nullptr, ip, dns); | ||
| } | ||
| int begin(IPAddress ip, IPAddress dns, IPAddress gateway) { | ||
| return begin(nullptr, ip, dns, gateway); | ||
| } | ||
| int begin(IPAddress ip, IPAddress dns, IPAddress gateway, IPAddress subnet) { | ||
| return begin(nullptr, ip, dns, gateway, subnet); | ||
| } |
There was a problem hiding this comment.
I would prefer to add fewer begins without the matrioska pattern to help the compiler to optimize the code. I would define only these two: @pennam what do you think about that?
int begin() override;
int begin(IPAddress ip, IPAddress dns=INADDR_NONE, IPAddress gateway=INADDR_NONE, IPAddress subnet=INADDR_NONE);
| @@ -66,9 +66,12 @@ EXPORT_SYMBOL(usb_disable); | |||
|
|
|||
| EXPORT_SYMBOL(z_log_msg_runtime_vcreate); | |||
|
|
|||
| FORCE_EXPORT_SYM(log_dynamic_sketch) | |||
There was a problem hiding this comment.
| FORCE_EXPORT_SYM(log_dynamic_sketch) | |
| #if defined(CONFIG_LOG) | |
| FORCE_EXPORT_SYM(log_dynamic_sketch) | |
| #endif // CONFIG_LOG |
| @@ -1,4 +1,211 @@ | |||
| #include "SocketHelpers.h" | |||
|
|
|||
| #include <zephyr/logging/log.h> | |||
| LOG_MODULE_DECLARE(sketch, LOG_LEVEL_NONE); | |||
There was a problem hiding this comment.
what do you think about using a log module named "sketch_networking" or something that is less generic than sketch?
There was a problem hiding this comment.
I would personally add a subset of examples that we are going to test in depth with a larger set of boards i.e. WebServer, WebClientRepeating, WebClientRepeatingSSL, UDPNtpClient. What do you think @pennam?
Ethernet)