Fix TypeError: 'type' object is not subscriptable #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syntax of list[], tuple[] are only supported since python3.9. This change makes this code runnable for python3.8
|
@ronenlu if you decide to land this, please make sure we add matrix tests for different python versions to make sure this fix doesn't break other users' apps. |
|
@mondwan Thank you for your contribution. But since python 3.8 is no longer officially supported, I dont think this fix is necessary. |
|
As py3.8 is marked on pyproject.toml, that's that's why I suppose this is a tool for supporting py3.8. Any suggested py version for running this tool then? |
You can run with latest py: 3.13 |
|
Sure, feel free to close the pull request then.
…On Tue, 22 Oct 2024, 12:29 Ronen Lubin, ***@***.***> wrote:
As py3.8 is marked on pyproject.toml
<https://github.com/ariga/atlas-provider-sqlalchemy/blob/master/pyproject.toml>,
that's that's why I suppose this is a tool for supporting py3.8.
Any suggested py version for running this tool then?
You can run with latest py: 3.13
—
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5YBI2LJBF2TDOPL6VTEY3Z4YZLDAVCNFSM6AAAAABQKWALJOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZGAZDONBSGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax of list[], tuple[] are only supported since python3.9. This change makes this code runnable for python3.8