update the extension to support manifest version 3 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for your contribution. |
|
When using the old mv2 version, if I open a new tab and enter http://reload.extensions/, I get the page saying 'This page has been blocked by an extension', so it looks like there is attempted navigation. The same behavior seems to happen when I use my mv3 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #28
I've done an update to mv3. It mostly consists of saving the 'state' variable in the extension's storage now. That's because service workers get shut down and their variables are reset. I have also removed 'webRequestBlocking' permission and its "blocking" related functionality in the webRequest in the background, because this is no longer avaialble in mv3. I don't know what the consequences will be for removing the "blocking" bit from the background. So far it seems to work fine.