Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(anta): Added the test case to verify the BGP route origin #813

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat(anta): Added the test case to verify the BGP route origin #813

wants to merge 13 commits into from

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Verifies BGP route origin for the provided IPv4 Network(s).

Expected Results
----------------
* Success: The test will pass if the BGP route's origin matches expected origin type.
* Failure: The test will fail if the BGP route's origin does not matches with expected origin type or BGP route entry(s) not found.

Fixes #811

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

MaheshGSLAB
MaheshGSLAB reviewed Sep 17, 2024
View reviewed changes
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

MaheshGSLAB
MaheshGSLAB reviewed Sep 24, 2024
View reviewed changes
anta/tests/routing/bgp.py Outdated Show resolved Hide resolved
examples/tests.yaml Outdated Show resolved Hide resolved
@vitthalmagadum
Copy link
Collaborator Author

Added pylint disable for no of line check (C0302) with TODO.
Thanks!!!

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 1, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #813 will not alter performance

Comparing vitthalmagadum:issue_811 (15d5964) with main (387c281)

Summary

✅ 8 untouched benchmarks

@gmuloc gmuloc mentioned this pull request Oct 10, 2024
Open
gmuloc
gmuloc reviewed Oct 10, 2024
View reviewed changes
anta/tests/routing/bgp.py Outdated
Comment on lines 1680 to 1683
route_paths: list[dict[str, IPv4Address | Literal["Igp", "Egp", "Incomplete"]]]
"""A list of dictionaries represents a BGP path.
- `nexthop`: The next-hop IP address for the path.
- `origin`: The origin of the route."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be modeled properly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated input model for BGP route paths.
Thanks!!

gmuloc
gmuloc requested changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cf question about model

@vitthalmagadum vitthalmagadum requested a review from gmuloc October 11, 2024 03:40
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 11, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@gmuloc gmuloc Awaiting requested review from gmuloc

Requested changes must be addressed to merge this pull request.

Assignees

@vitthalmagadum vitthalmagadum

Labels
state: conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test case to verify the BGP route origin.
3 participants
@vitthalmagadum @gmuloc @MaheshGSLAB