-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(anta): Added the test case for verify BGP peer group of the BGP IPv4 peer(s) #815
base: main
Are you sure you want to change the base?
Conversation
anta/tests/routing/bgp.py
Outdated
peer = command.params.peer | ||
vrf = command.params.vrf | ||
peer_group = input_entry.peer_group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can collect the peer and vrf from input_entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
anta/tests/routing/bgp.py
Outdated
failure_log = f"Expected `{peer_group}` as the configured peer-group, but found `{actual_peer_group}` instead." | ||
if not actual_peer_group: | ||
failure_log = "Peer-group not configured." | ||
failures[peer] = failure_log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so when peer not configured we are giving the vrf information but while it is not correct we are missing it to add vrf information. Please correct it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Thanks!!
54096a4
to
07ae814
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
63da029
to
7529a1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the pre-commit by disable the line warning issue
Quality Gate passedIssues Measures |
CodSpeed Performance ReportMerging #815 will not alter performanceComparing Summary
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Description
Verifies BGP peer group of the BGP IPv4 peer(s).
Fixes #810
Checklist:
pre-commit run
)tox -e testenv
)