feat(anta): Added the test case to verify SNMP user #877
Conversation
CodSpeed Performance ReportMerging #877 will not alter performanceComparing Summary
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
vitthalmagadum
force-pushed
the
issue_852
branch
from
8dd61b3
to
1119961
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
| class Input(AntaTest.Input): | ||
| """Input model for the VerifySnmpUser test.""" | ||
|
|
||
| users: list[SnmpUser] |
There was a problem hiding this comment.
| users: list[SnmpUser] | |
| snmp_users: list[SnmpUser] |
| security_model: SnmpVersion | ||
| """SNMP protocol version..""" | ||
| authentication_type: HashingAlgorithms | None = None | ||
| """User authentication settings.""" |
There was a problem hiding this comment.
We should give the information here for which version auth and privacy needed
| """SNMP protocol version..""" | ||
| authentication_type: HashingAlgorithms | None = None | ||
| """User authentication settings.""" | ||
| priv_type: EncryptionAlgorithms | None = None |
There was a problem hiding this comment.
| priv_type: EncryptionAlgorithms | None = None | |
| encryption: EncryptionAlgorithms | None = None |
| def validate_inputs(self: BaseModel) -> BaseModel: | ||
| """Validate the inputs provided to the SnmpUser class.""" | ||
| if self.security_model in ["v1", "v2c"] and (self.authentication_type or self.priv_type) is not None: | ||
| msg = "SNMP versions 1 and 2c, do not support encryption or advanced authentication." |
There was a problem hiding this comment.
So we should use the validator in case if a input is required for a case. So i think if a user provide the the version as v3 in that case we should raise the error that encryption and authentication is required.
| actual_user_details = {"user group": user_details.get("groupName", "Not Found")} | ||
|
|
||
| if authentication_type: | ||
| expected_user_details["authentication type"] = authentication_type |
There was a problem hiding this comment.
can you add a unit test for not found params
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Description
Verifies the SNMP user configurations for specified version(s).
Fixes #852
Checklist:
pre-commit run)tox -e testenv)