Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta.tests): Cleaning up Security tests module (VerifySpecificIPSecConn) #933

Merged
merged 10 commits into from
Dec 4, 2024

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Refactoring Security tests module to address the following issues:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #933 will not alter performance

Comparing vitthalmagadum:feat/Security (75826e7) with main (a5996f2)

Summary

✅ 8 untouched benchmarks

@vitthalmagadum vitthalmagadum marked this pull request as draft November 26, 2024 13:25
@vitthalmagadum vitthalmagadum marked this pull request as ready for review November 28, 2024 06:53
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
anta/tests/security.py Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 4, 2024

@gmuloc gmuloc merged commit cc10fb0 into aristanetworks:main Dec 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants