Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(anta.tests): Cleaning up STUN tests module #934

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

vitthalmagadum
Copy link
Collaborator

Description

Refactoring STUN tests module to address the following issues:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #934 will not alter performance

Comparing vitthalmagadum:feat/stun (409158d) with main (a5996f2)

Summary

✅ 8 untouched benchmarks

anta/tests/stun.py Outdated Show resolved Hide resolved
anta/tests/stun.py Outdated Show resolved Hide resolved
anta/tests/stun.py Outdated Show resolved Hide resolved
anta/tests/stun.py Outdated Show resolved Hide resolved
anta/tests/stun.py Outdated Show resolved Hide resolved
anta/tests/stun.py Outdated Show resolved Hide resolved
anta/tests/stun.py Outdated Show resolved Hide resolved
anta/input_models/stun.py Outdated Show resolved Hide resolved

class VerifyStunClientTranslation(AntaTest):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be backward compatible (SemVer) lets add VerifyStunClient with the deprecation warning (you have a decorator for this)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets see if we can make it an alias .. :)

Copy link
Contributor

github-actions bot commented Dec 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

sonarcloud bot commented Dec 3, 2024

@gmuloc gmuloc mentioned this pull request Dec 3, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants