Feat(eos_cli_config_gen): Add switchport 'tap' and 'tool' mode config to the ethernet and port-channel interfaces

[Shivani-gslab]

Change Summary

Add switchport 'tap' and 'tool' mode config to the interfaces

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add schema, template and tests for switchport.tap and switchport.tool in interfaces.

How to test

Molecule test added. Test in EOS CLI.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4174
# Activate the virtual environment
source test-avd-pr-4174/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@switchport_tap_tool#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,switchport_tap_tool --force
# Optional: Install AVD examples
cd test-avd-pr-4174
ansible-playbook arista.avd.install_examples

A lot of changes since then

[gmuloc]

partial review as I need to find a correct device to carry on

[gmuloc]

this is rendered as

switchport tap encapsulation gre protocol 0x1 strip not 0x0001 (need to check the tempaltes to conclude myself)

[Shivani-gslab]

yes, I kept it same as the command

[gmuloc]

this line disappears in my config

[Shivani-gslab]

its there for me -

interface Ethernet10
   description Switchport_tap_tool
   switchport tap native vlan 10
   switchport tap identity 3 inner 5
   switchport tap mac-address dest 01:00:00:00:00:00 src 01:23:45:67:89:ab
   switchport tap encapsulation gre protocol 0x1 strip
   switchport tap encapsulation gre protocol 0x2 feature header length 3 strip
   switchport tap encapsulation gre protocol 0x3 feature header length 2 strip re-encapsulation ethernet
   switchport tap encapsulation gre protocol 0x4 strip re-encapsulation ethernet
   switchport tap encapsulation gre strip
   switchport tap encapsulation gre destination 1.1.1.1 source 1.1.1.2 protocol 0x0 strip
   switchport tap encapsulation gre destination 2.1.1.2 protocol 0x10 strip
   switchport tap encapsulation gre destination 2.1.1.2 protocol 0x11 feature header length 2 strip re-encapsulation ethernet
   switchport tap encapsulation gre destination 2.1.1.2 protocol 0x12 strip re-encapsulation ethernet
   switchport tap mpls pop all
   switchport tool mpls pop all
   switchport tool encapsulation vn-tag strip
   switchport tool encapsulation dot1br strip
   switchport tap allowed vlan 25
   switchport tool allowed vlan 23
   switchport tool identity qinq
   switchport tool identity dot1q source dzgre port
   switchport tap truncation 150
   switchport tool truncation 1
   switchport tap default group g1 group g2 group g3
   switchport tap default nexthop-group nexthop_g1 nexthop_g2 nexthop_g3
   switchport tap default interface Ethernet4
   switchport tap default interface Po10
   switchport tool group set group1 group2
   switchport tool dot1q remove outer 1

[Shivani-gslab]

tested multiple ways, found out that - it replaces that command when we apply switchport tap encapsulation gre destination 2.1.1.2 strip i.e. without specifying protocol and vice-versa.

[gmuloc]

which device have you used for this?

site3-leaf1(config-s-gmu)#interface Port-Channel100.101
site3-leaf1(config-s-gmu-if-Po100.101)##interface Port-Channel100.101
% Invalid input
site3-leaf1(config-s-gmu-if-Po100.101)#   description IFL for TENANT01
site3-leaf1(config-s-gmu-if-Po100.101)#   mtu 1500
site3-leaf1(config-s-gmu-if-Po100.101)#   logging event link-status
site3-leaf1(config-s-gmu-if-Po100.101)#   encapsulation dot1q vlan 101
site3-leaf1(config-s-gmu-if-Po100.101)#   ip address 10.1.1.3/31
site3-leaf1(config-s-gmu-if-Po100.101)#   switchport tap identity 3 inner 10
% Invalid input
site3-leaf1(config-s-gmu-if-Po100.101)#   switchport tap mac-address dest 01:00:00:00:00:00
% Invalid input
site3-leaf1(config-s-gmu-if-Po100.101)#   switchport tap encapsulation vxlan strip
% Invalid input
site3-leaf1(config-s-gmu-if-Po100.101)#   switchport tool identity dot1q
% Invalid input
site3-leaf1(config-s-gmu-if-Po100.101)#   switchport tool identity dot1q source dzgre policy
% Invalid input
site3-leaf1(config-s-gmu-if-Po100.101)#   switchport tap truncation 120
% Invalid input
site3-leaf1(config-s-gmu-if-Po100.101)#   switchport tool truncation
% Invalid input
site3-leaf1(config-s-gmu-if-Po100.101)#switch?
switch  switchport

site3-leaf1(config-s-gmu-if-Po100.101)#switchport ?
  default        Configure switchport default behavior
  ethernet       Details on Ethernet 802.2 LLC header operation
  port-security  Configure MAC-address-based port security
  vlan           Details on VLAN operation

[Shivani-gslab]

ahh, it has the same issue (not applicable to sub interfaces)

[Shivani-gslab]

Fixed it

[gmuloc]

Suggested change

	Protocol range: 0x0000-0xFFFF.
	Protocol range: 0x0-0xFFFF.

[Shivani-gslab]

Fixed