Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(cv_deploy): Add support for new studio_topology API #4859

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add support for new studio_topology API

Component(s) name

arista.avd.cv_workflow
arista.avd.cv_deploy

Proposed changes

  • Add support for new studio_topology resource API but still prefer the legacy studio inputs api for topology studio.
  • Later we will flip the preference based on versions and later again remove the legacy api for later versions.

How to test

Tested manually on CVaaS.

  • Expecting no behavioral changes.
  • Checked log messages for old and new api (try old, fail old, try new)
  • Tested with molecule cv_workflow.

Requires flipping an alpha toggle per tenant, and after flipping it the backend needs to migrate data before the new API works. So avoid flipping back and forth.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners January 7, 2025 06:46
Copy link

github-actions bot commented Jan 7, 2025

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4859
# Activate the virtual environment
source test-avd-pr-4859/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/cv_workspace/add-new-studio-topology-api#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/cv_workspace/add-new-studio-topology-api --force
# Optional: Install AVD examples
cd test-avd-pr-4859
ansible-playbook arista.avd.install_examples

@ClausHolbechArista ClausHolbechArista changed the title Refactor(cv_workflow): Add support for new studio_topology API Refactor(cv_deploy): Add support for new studio_topology API Jan 7, 2025
@carlbuchmann carlbuchmann marked this pull request as draft January 8, 2025 19:16
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 30, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: conflict PR with conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant