Feat(eos_cli_config_gen): Add interface TE twamp-light with fallback knobs

[emilarista]

…knobs

Change Summary

Add dynamic min-delay with twamp-light and fallback knobs.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

- name: Ethernet81/4
    ...
    traffic_engineering:
      ...
      min_delay_dynamic:
        twamp_light_fallback:
          number: 2
          unit: milliseconds

How to test

Tested with molecule and on device.

Checklist

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4935
# Activate the virtual environment
source test-avd-pr-4935/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/emilarista/ansible-avd.git@eos_cli_config_gen/if-te-twamp-fallback#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/emilarista/ansible-avd.git#/ansible_collections/arista/avd/,eos_cli_config_gen/if-te-twamp-fallback --force
# Optional: Install AVD examples
cd test-avd-pr-4935
ansible-playbook arista.avd.install_examples

[alexeygorbunov]

LGTM

[MaheshGSLAB]

Limit vary according to unit. The current limit is in microseconds.

wan1-dc1(config-if-Po130)# traffic-engineering min-delay dynamic twamp-light fallback 16777214 milli
seconds
% Minimum delay value exceeds 16777215 us

[emilarista]

You are right, the cli does not hint this unless you try to configure it. Should i remove the min/max setting and add description with limits or change the data model and make something like twamp_light_fallback.milliseconds/....microseconds to have separate min/max values?

[alexeygorbunov]

yeah, same issue is applicable to the existing implementation for static delay:

veos-4-33-0f(config-s-s7b-if-Et5)#traffic-engineering min-delay static 16777215 milliseconds 
% Minimum delay value exceeds 16777215 us
veos-4-33-0f(config-s-s7b-if-Et5)#traffic-engineering min-delay static 16777215 microseconds 
veos-4-33-0f(config-s-s7b-if-Et5)#

Maximum min-delay in milliseconds is 16777

veos-4-33-0f(config-s-s7b-if-Et5)#traffic-engineering min-delay static 16777 milliseconds 
veos-4-33-0f(config-s-s7b-if-Et5)#traffic-engineering min-delay static 16778 milliseconds
% Minimum delay value exceeds 16777215 us
veos-4-33-0f(config-s-s7b-if-Et5)#

[MaheshGSLAB]

You are right, the cli does not hint this unless you try to configure it. Should i remove the min/max setting and add description with limits or change the data model and make something like twamp_light_fallback.milliseconds/....microseconds to have separate min/max values?

Yes i think we can remove the min/max and update the limit in description for both milli and micro seconds. But lets confirm from @ClausHolbechArista @gmuloc too.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud