Refactor(eos_designs): Refactor eos_designs structured_config code for ip_nat #4944
+40
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4944
# Activate the virtual environment
source test-avd-pr-4944/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@refactor_ip_nat#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,refactor_ip_nat --force
# Optional: Install AVD examples
cd test-avd-pr-4944
ansible-playbook arista.avd.install_examples |
Shivani-gslab
force-pushed
the
refactor_ip_nat
branch
2 times, most recently
from
bc65303 to
08eacae
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Shivani-gslab
force-pushed
the
refactor_ip_nat
branch
from
08eacae to
fbfcf83
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor eos_designs structured_config code for ip_nat
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Refactor eos_designs structured_config code for ip_nat
How to test
Checklist
User Checklist
Repository Checklist