eext: Adding source bundle capability for eext packages to invoke using repoName #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manith-arista
force-pushed
the
manith-renameUrl
branch
from
7294b3b
to
ca95a05
Compare
manith-arista
force-pushed
the
manith-renameUrl
branch
2 times, most recently
from
7dcd606
to
91a09e2
Compare
manith-arista
force-pushed
the
manith-renameUrl
branch
2 times, most recently
from
3857525
to
b447e27
Compare
aajith-arista
requested changes
Sep 14, 2023
manith-arista
force-pushed
the
manith-renameUrl
branch
from
b447e27
to
ae06bd0
Compare
aajith-arista
previously approved these changes
Sep 19, 2023
manith-arista
force-pushed
the
manith-renameUrl
branch
2 times, most recently
from
080334d
to
792dbc4
Compare
To support srpms to be hosted on artifactory repo, we provide full-url option. Also added support for source bundles, which consist of a predefined format, based on release version.
Created template for source bundle with srcconfig, for packages to refer using repoName. Added logic to expand url template of source rpms fro pacakge manifest data. Updated tests to utilize the source bundles instead of srpm urls.
Added viper setup configuration and default values for srcconfig parameters.
Added logic to parse srcconfig template, read package manifest and retrieve corresponding source bundle for building srpm.
Packages can specify {.Host} parameter in thier manifests instead of
specifying the source repo url.
Verify functionality of source config bundle by updating the test case to obtain srpm for repo using custom src bundle.
Release macro in eext packages' spec files were created with incorrect values. Issue arises due to naming the rpmReleaseMacro as 'release' too, which conflicts with the macro for 'Release'. Instead using 'eext_release' to denote rpmReleaseMacro to resolve conflict.
manith-arista
force-pushed
the
manith-renameUrl
branch
from
4a547e3
to
1fda617
Compare
aajith-arista
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new feature to support source bundles for eext packages.
Eext packages can now invoke pre-defined source bundles to define source and signature of srpm, which will allow easier version control of srpms, distro upgrades and less clutter in manifest files.