Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libtool to eext base-image #90

Closed
wants to merge 1 commit into from
Closed

Conversation

dzmaroz
Copy link
Member

@dzmaroz dzmaroz commented Sep 27, 2023

Libtool is needed to build curl in eext.

Libtool is needed to make srpms for curl.
@dzmaroz dzmaroz self-assigned this Sep 27, 2023
@aajith-arista
Copy link
Collaborator

Is the curl spec file using libtool in %prep itself ? Only %prep is run in the base image, all other deps are satisifed by mock itself.

The prep in base-image is just a nice-to-have thing to see if patches apply cleanly in create-srpm itself, otherwise we'll defer prep to actual run of mock and fail a little late.
An alternative is to use --skip-build-prep option to eext.

@dzmaroz
Copy link
Member Author

dzmaroz commented Sep 28, 2023

Is the curl spec file using libtool in %prep itself ? Only %prep is run in the base image, all other deps are satisifed by mock itself.

The prep in base-image is just a nice-to-have thing to see if patches apply cleanly in create-srpm itself, otherwise we'll defer prep to actual run of mock and fail a little late. An alternative is to use --skip-build-prep option to eext.

Yes, in %prep itself.
Thanks for clarification. Then I'll just drop this PR and use --skip-build-prep instead. A little delay in %prep doesn't seem to be critical.

@dzmaroz dzmaroz closed this Sep 28, 2023
@dzmaroz dzmaroz deleted the add-libtool-to-base-image branch September 28, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants