Add comments to address review #46
arjan-balAnnotations
12 errors
|
vet-proto
Process completed with exit code 1.
|
|
tests (vet, 1.22):
xds/internal/httpfilter/router/router.go#L57
redefinition of the built-in type any https://revive.run/r#redefines-builtin-id
|
|
tests (vet, 1.22):
reflection/test/grpc_testing_not_regenerate/dynamic.go#L18
don't use an underscore in package name https://revive.run/r#var-naming
|
|
tests (vet, 1.22):
reflection/test/grpc_testing_not_regenerate/testv3.go#L382
context.Context should be the first parameter of a function https://revive.run/r#context-as-argument
|
|
tests (vet, 1.22):
reflection/test/grpc_testing_not_regenerate/testv3.go#L56
exported type SearchResponseV3_State should have comment or be unexported https://revive.run/r#exported
|
|
tests (vet, 1.22):
reflection/test/grpc_testing_not_regenerate/testv3.go#L59
exported const SearchResponseV3_UNKNOWN should have comment (or a comment on this block) or be unexported https://revive.run/r#exported
|
|
tests (vet, 1.22):
reflection/test/grpc_testing_not_regenerate/testv3.go#L64
exported var SearchResponseV3_State_name should have comment or be unexported https://revive.run/r#exported
|
|
tests (vet, 1.22):
reflection/test/grpc_testing_not_regenerate/testv3.go#L69
exported var SearchResponseV3_State_value should have comment or be unexported https://revive.run/r#exported
|
|
tests (vet, 1.22):
reflection/test/grpc_testing_not_regenerate/testv3.go#L78
exported method SearchResponseV3_State.EnumDescriptor should have comment or be unexported https://revive.run/r#exported
|
|
tests (vet, 1.22):
reflection/test/grpc_testing_not_regenerate/testv3.go#L80
exported type SearchResponseV3 should have comment or be unexported https://revive.run/r#exported
|
|
tests (vet, 1.22):
reflection/test/grpc_testing_not_regenerate/testv3.go#L85
exported method SearchResponseV3.Reset should have comment or be unexported https://revive.run/r#exported
|
|
tests (tests, 1.22, -race, GRPC_EXPERIMENTAL_ENABLE_NEW_PICK_FIRST=true)
Process completed with exit code 1.
|