Skip to content

Address review comments #115

Address review comments

Address review comments #115

Triggered via push September 6, 2024 10:39
Status Failure
Total duration 5m 54s
Artifacts

testing.yml

on: push
vet-proto
24s
vet-proto
Matrix: tests
Fit to window
Zoom out
Zoom in

Annotations

12 errors
vet-proto
Process completed with exit code 1.
tests (vet, 1.22): examples/features/opentelemetry/client/main.go#L19
should have a package comment https://revive.run/r#package-comments
tests (vet, 1.22): internal/balancer/gracefulswitch/config.go#L59
this block is empty, you can remove it https://revive.run/r#empty-block
tests (vet, 1.22): internal/channelz/server.go#L62
exported method ServerMetrics.CopyFrom should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/channelz/socket.go#L73
exported type SocketType should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/channelz/subchannel.go#L50
exported method SubChannel.Sockets should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/channelz/trace.go#L82
exported type ChannelTrace should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/channelz/channel.go#L64
exported method Channel.SubChans should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/idle/idle.go#L185
exported method Manager.EnterIdleModeForTesting should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/stats/metrics_recorder_list.go#L57
exported method MetricsRecorderList.RecordInt64Count should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/serviceconfig/serviceconfig.go#L93
this block is empty, you can remove it https://revive.run/r#empty-block
tests (tests, 1.22, arm64)
Process completed with exit code 1.