Skip to content

Address review comments #117

Address review comments

Address review comments #117

Triggered via push September 6, 2024 10:46
Status Failure
Total duration 6m 11s
Artifacts

testing.yml

on: push
vet-proto
27s
vet-proto
Matrix: tests
Fit to window
Zoom out
Zoom in

Annotations

11 errors
vet-proto
Process completed with exit code 1.
tests (vet, 1.22): internal/status/status.go#L141
redefinition of the built-in type any https://revive.run/r#redefines-builtin-id
tests (vet, 1.22): xds/internal/httpfilter/router/router.go#L57
redefinition of the built-in type any https://revive.run/r#redefines-builtin-id
tests (vet, 1.22): balancer/pickfirst/pickfirst.go#L112
exported type Shuffler should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): balancer/pickfirst/pickfirst.go#L116
exported function ShuffleAddressListForTesting should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/idle/idle.go#L185
exported method Manager.EnterIdleModeForTesting should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): internal/idle/idle.go#L269
exported method Manager.Close should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): reflection/test/grpc_testing_not_regenerate/testv3.go#L56
exported type SearchResponseV3_State should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): reflection/test/grpc_testing_not_regenerate/testv3.go#L59
exported const SearchResponseV3_UNKNOWN should have comment (or a comment on this block) or be unexported https://revive.run/r#exported
tests (vet, 1.22): reflection/test/grpc_testing_not_regenerate/testv3.go#L64
exported var SearchResponseV3_State_name should have comment or be unexported https://revive.run/r#exported
tests (vet, 1.22): reflection/test/grpc_testing_not_regenerate/testv3.go#L69
exported var SearchResponseV3_State_value should have comment or be unexported https://revive.run/r#exported